Permalink
Browse files

test: replace assert.equal with assert.strictEqual

Using NodeTodo I learned of a need to swap out the .equal function
with .strictEqual in a few test files.

https://twitter.com/NodeTodo/status/803657321993961472
https://gist.github.com/Trott/864401455d4afa2428cd4814e072bd7c

additional commits squashed:
.strictEqual's argument signature is actual, expected, [message].
Previously some statements were listed as expected, actual.
As asked in PR i swapped them to match the correct argument signature.

PR-URL: #9842
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information...
brad-decker authored and Trott committed Nov 29, 2016
1 parent cf71915 commit 18016d3b3fd27fd2744a17a54f15631af6206df1
@@ -4,7 +4,7 @@ var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
binding(5, common.mustCall(function(err, val) {
assert.equal(null, err);
assert.equal(10, val);
assert.strictEqual(err, null);
assert.strictEqual(val, 10);
process.nextTick(common.mustCall(function() {}));
}));
@@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding());
assert.strictEqual(binding(), 'world');
console.log('binding.hello() =', binding());
@@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding.hello());
assert.strictEqual(binding.hello(), 'world');
console.log('binding.hello() =', binding.hello());
@@ -34,4 +34,4 @@ fs.writeFileSync(addonDestinationPath, contents);
// Attempt to load at long path destination
var addon = require(addonDestinationPath);
assert.notEqual(addon, null);
assert.equal(addon.hello(), 'world');
assert.strictEqual(addon.hello(), 'world');
@@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}
const maxString = buf.toString('latin1');
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
@@ -34,9 +34,9 @@ assert.throws(function() {
}, /"toString\(\)" failed/);
var maxString = buf.toString('latin1', 1);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
// Free the memory early instead of at the end of the next assignment
maxString = undefined;
maxString = buf.toString('latin1', 0, kStringMaxLength);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
@@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}
const maxString = buf.toString('utf16le');
assert.equal(maxString.length, (kStringMaxLength + 2) / 2);
assert.strictEqual(maxString.length, (kStringMaxLength + 2) / 2);

0 comments on commit 18016d3

Please sign in to comment.