Permalink
Browse files

test: enable setuid/setgid test

Refactor test for situations where it was expected to fail.
Move from disabled directory to parallel.

PR-URL: #12403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information...
Trott committed Apr 13, 2017
1 parent b837bd2 commit 189afc8dc2a4a01e6e97493e167ad6d2db6ff065
Showing with 40 additions and 16 deletions.
  1. +40 −16 test/{disabled/test-setuidgid.js → parallel/test-process-setuid-setgid.js}
@@ -20,25 +20,49 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
-// Requires special privileges
const common = require('../common');
+
const assert = require('assert');
-var oldgid = process.getgid();
-process.setgid('nobody');
-var newgid = process.getgid();
-assert.notStrictEqual(newgid, oldgid, 'gids expected to be different');
+if (common.isWindows) {
+ // uid/gid functions are POSIX only
+ assert.strictEqual(process.getuid, undefined);
+ assert.strictEqual(process.setuid, undefined);
+ assert.strictEqual(process.getgid, undefined);
+ assert.strictEqual(process.setgid, undefined);
+ return;
+}
-var olduid = process.getuid();
-process.setuid('nobody');
-var newuid = process.getuid();
-assert.notStrictEqual(newuid, olduid, 'uids expected to be different');
-
-try {
- process.setuid('nobody1234');
-} catch (e) {
- assert.strictEqual(e.message,
- 'failed to resolve group',
- 'unexpected error message'
+assert.throws(() => {
+ process.setuid('fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf');
+}, /^Error: setuid user id does not exist$/);
+
+// If we're not running as super user...
+if (process.getuid() !== 0) {
+ assert.doesNotThrow(() => {
+ process.getgid();
+ process.getuid();
+ });
+
+ assert.throws(
+ () => { process.setgid('nobody'); },
+ /^Error: (EPERM, .+|setgid group id does not exist)$/
);
+
+ assert.throws(
+ () => { process.setuid('nobody'); },
+ /^Error: EPERM, /
+ );
+ return;
}
+
+// If we are running as super user...
+const oldgid = process.getgid();
+process.setgid('nobody');
+const newgid = process.getgid();
+assert.notStrictEqual(newgid, oldgid);
+
+const olduid = process.getuid();
+process.setuid('nobody');
+const newuid = process.getuid();
+assert.notStrictEqual(newuid, olduid);

0 comments on commit 189afc8

Please sign in to comment.