Skip to content
Permalink
Browse files

test: mitigate flaky test-debug-no-context

Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott authored and MylesBorins committed Feb 17, 2016
1 parent 0931112 commit 18e3987e2e8a0e2c1abce1322563445038b232c9
Showing with 4 additions and 2 deletions.
  1. +4 −2 test/parallel/test-debug-no-context.js
@@ -5,14 +5,16 @@ const assert = require('assert');
const spawn = require('child_process').spawn;

const args = ['--debug', `--debug-port=${common.PORT}`, '--interactive'];
const proc = spawn(process.execPath, args, { stdio: 'pipe' });
const proc = spawn(process.execPath, args);
proc.stdin.write(`
util.inspect(Promise.resolve(42));
util.inspect(Promise.resolve(1337));
.exit
`);
proc.on('exit', common.mustCall((exitCode, signalCode) => {
assert.strictEqual(exitCode, 0);
// This next line should be included but unfortunately Win10 fails from time
// to time in CI. See https://github.com/nodejs/node/issues/5268
// assert.strictEqual(exitCode, 0);
assert.strictEqual(signalCode, null);
}));
let stdout = '';

0 comments on commit 18e3987

Please sign in to comment.
You can’t perform that action at this time.