Permalink
Browse files

test: replace Google servers with localhost

Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
Trott authored and addaleax committed Jan 25, 2019
1 parent 14bce1e commit 190c063ecb6ce1a410f5fdbc69bad789af171a10
Showing with 3 additions and 6 deletions.
  1. +3 −6 test/parallel/test-dns-setserver-when-querying.js
@@ -4,10 +4,7 @@ const common = require('../common');

const dns = require('dns');

const goog = [
'8.8.8.8',
'8.8.4.4',
];
const localhost = [ '127.0.0.1' ];

{
// Fix https://github.com/nodejs/node/issues/14734
@@ -16,7 +13,7 @@ const goog = [
const resolver = new dns.Resolver();
resolver.resolve('localhost', common.mustCall());

common.expectsError(resolver.setServers.bind(resolver, goog), {
common.expectsError(resolver.setServers.bind(resolver, localhost), {
code: 'ERR_DNS_SET_SERVERS_FAILED',
message: /^c-ares failed to set servers: "There are pending queries\." \[.+\]$/g
});
@@ -26,6 +23,6 @@ const goog = [
dns.resolve('localhost', common.mustCall());

// should not throw
dns.setServers(goog);
dns.setServers(localhost);
}
}

0 comments on commit 190c063

Please sign in to comment.