Permalink
Browse files

http: fix regression of binary upgrade response body

PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information...
mcollina authored and MylesBorins committed Dec 14, 2018
1 parent 728bc63 commit 1aea1e3634de7331f670f0594c023ca7c64a759f
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/node_http_parser.cc
@@ -605,8 +605,6 @@ class Parser : public AsyncWrap, public StreamListener {
size_t nparsed =
http_parser_execute(&parser_, &settings, data, len);

enum http_errno err = HTTP_PARSER_ERRNO(&parser_);

Save();

// Unassign the 'buffer_' variable
@@ -621,7 +619,9 @@ class Parser : public AsyncWrap, public StreamListener {
Local<Integer> nparsed_obj = Integer::New(env()->isolate(), nparsed);
// If there was a parse error in one of the callbacks
// TODO(bnoordhuis) What if there is an error on EOF?
if ((!parser_.upgrade && nparsed != len) || err != HPE_OK) {
if (!parser_.upgrade && nparsed != len) {
enum http_errno err = HTTP_PARSER_ERRNO(&parser_);

Local<Value> e = Exception::Error(env()->parse_error_string());
Local<Object> obj = e->ToObject(env()->isolate()->GetCurrentContext())
.ToLocalChecked();

0 comments on commit 1aea1e3

Please sign in to comment.