Skip to content
Permalink
Browse files

deps: silence irrelevant V8 warnings

PR-URL: #25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information...
targos committed Mar 13, 2019
1 parent ff5d632 commit 1c494b0a9500d4ec27330ff7ed55865112a5ee77
Showing with 3 additions and 4 deletions.
  1. +1 −1 deps/v8/gypfiles/toolchain.gypi
  2. +2 −3 deps/v8/include/v8.h
@@ -1393,7 +1393,7 @@
], # conditions
}, # Release
}, # configurations
'cflags': [ '-Wno-type-limits', ],
'cflags!': [ '-Wall', '-Wextra' ],
'msvs_disabled_warnings': [
4245, # Conversion with signed/unsigned mismatch.
4267, # Conversion with possible loss of data.
@@ -4337,14 +4337,13 @@ class V8_EXPORT CompiledWasmModule {
class V8_EXPORT WasmModuleObject : public Object {
public:
// TODO(clemensh): Remove after 7.3 branch.
V8_DEPRECATED("Use OwnedBuffer", typedef)
std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;

/**
* A unowned reference to a byte buffer.
* TODO(clemensh): Remove after 7.3 branch.
*/
V8_DEPRECATED("Use MemorySpan<const uint8_t>", struct) BufferReference {
struct BufferReference {
const uint8_t* start;
size_t size;
BufferReference(const uint8_t* start, size_t size)

0 comments on commit 1c494b0

Please sign in to comment.
You can’t perform that action at this time.