From 1ce94164a53e9290a8ea4d3acf71505ebebce558 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 2 Sep 2018 20:15:51 +0200 Subject: [PATCH] test: fix flaky addons/callback-scope/test-resolve-async MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: https://github.com/nodejs/node/issues/22668 PR-URL: https://github.com/nodejs/node/pull/22664 Reviewed-By: Tobias Nießen Reviewed-By: Denys Otrishko Reviewed-By: Luigi Pinca Reviewed-By: George Adams Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- test/addons/callback-scope/test-resolve-async.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/addons/callback-scope/test-resolve-async.js b/test/addons/callback-scope/test-resolve-async.js index 98e1910b49df7b..c2942397737359 100644 --- a/test/addons/callback-scope/test-resolve-async.js +++ b/test/addons/callback-scope/test-resolve-async.js @@ -4,7 +4,9 @@ const common = require('../../common'); const assert = require('assert'); const { testResolveAsync } = require(`./build/${common.buildType}/binding`); +// Checks that resolving promises from C++ works. + let called = false; testResolveAsync().then(() => { called = true; }); -setTimeout(() => { assert(called); }, common.platformTimeout(50)); +process.on('beforeExit', () => { assert(called); });