Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
test: bind to 0 in dgram-send-callback-buffer-length
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a dynamic port used in another test will
collide with common.PORT.

PR-URL: #12943
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
  • Loading branch information
arturgvieira authored and MylesBorins committed Jul 17, 2017
1 parent 7909c6d commit 1d35965
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/parallel/test-dgram-send-callback-buffer-length.js
Expand Up @@ -17,4 +17,7 @@ const messageSent = common.mustCall(function messageSent(err, bytes) {
client.close();
});

client.send(buf, offset, len, common.PORT, '127.0.0.1', messageSent);
client.bind(0, () => client.send(buf, offset, len,
client.address().port,
'127.0.0.1',
messageSent));

0 comments on commit 1d35965

Please sign in to comment.