Skip to content
Permalink
Browse files

test: add `emitClose: true` tests for fs streams

PR-URL: #29212
Fixes: #29177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information...
Trott authored and BridgeAR committed Aug 22, 2019
1 parent 8f47ff1 commit 1f88ca34243142b79dd6a48dabd81280bbaedddf
Showing with 25 additions and 2 deletions.
  1. +25 −2 test/parallel/test-fs-stream-destroy-emit-error.js
@@ -6,8 +6,31 @@ const fs = require('fs');
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

test(fs.createReadStream(__filename));
test(fs.createWriteStream(`${tmpdir.path}/dummy`));
{
const stream = fs.createReadStream(__filename);
stream.on('close', common.mustNotCall());
test(stream);
}

{
const stream = fs.createWriteStream(`${tmpdir.path}/dummy`);
stream.on('close', common.mustNotCall());
test(stream);
}

{
const stream = fs.createReadStream(__filename, { emitClose: true });
stream.on('close', common.mustCall());
test(stream);
}

{
const stream = fs.createWriteStream(`${tmpdir.path}/dummy2`,
{ emitClose: true });
stream.on('close', common.mustCall());
test(stream);
}


function test(stream) {
const err = new Error('DESTROYED');

0 comments on commit 1f88ca3

Please sign in to comment.
You can’t perform that action at this time.