From 2224211609cce06f1859f7b00cb5ef01e10739aa Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 8 Feb 2020 06:14:14 -1000 Subject: [PATCH] test: improve assertion message in test-dns-any Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: https://github.com/nodejs/node/pull/31697 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell --- test/internet/test-dns-any.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/internet/test-dns-any.js b/test/internet/test-dns-any.js index e8425a6ca5632d..3e8eb07e7e6e52 100644 --- a/test/internet/test-dns-any.js +++ b/test/internet/test-dns-any.js @@ -119,8 +119,8 @@ TEST(async function test_google(done) { function validateResult(res) { const types = processResult(res); assert.ok( - types.A && types.AAAA && types.MX && - types.NS && types.TXT && types.SOA); + types.A && types.AAAA && types.MX && types.NS && types.TXT && types.SOA, + `Missing record type, found ${Object.keys(types)}`); } validateResult(await dnsPromises.resolve('google.com', 'ANY')); @@ -140,7 +140,8 @@ TEST(async function test_google(done) { TEST(async function test_sip2sip_for_naptr(done) { function validateResult(res) { const types = processResult(res); - assert.ok(types.A && types.NS && types.NAPTR && types.SOA); + assert.ok(types.A && types.NS && types.NAPTR && types.SOA, + `Missing record type, found ${Object.keys(types)}`); } validateResult(await dnsPromises.resolve('sip2sip.info', 'ANY'));