From 245469587c7a6326d1b55bdf6c6d6650d72bfa22 Mon Sep 17 00:00:00 2001 From: Ryan Graham Date: Mon, 7 Jul 2014 17:04:42 -0700 Subject: [PATCH] lib: noisy deprecation of child_process customFds Use a util.deprecate wrapper to issue warnings like any other deprecated API. The option has been marked as deprecated in the docs since v0.5.11. Signed-off-by: Fedor Indutny --- lib/child_process.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/child_process.js b/lib/child_process.js index ac8de76adaafbc..7bcd6d95f8ed6e 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -804,12 +804,15 @@ exports.execFile = function(file /* args, options, callback */) { return child; }; +var _deprecatedCustomFds = util.deprecate(function(options) { + options.stdio = options.customFds.map(function(fd) { + return fd === -1 ? 'pipe' : fd; + }); +}, 'child_process: customFds option is deprecated, use stdio instead.'); function _convertCustomFds(options) { if (options && options.customFds && !options.stdio) { - options.stdio = options.customFds.map(function(fd) { - return fd === -1 ? 'pipe' : fd; - }); + _deprecatedCustomFds(options); } }