Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: initialize ICU version in per_process::metadata.versions
Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again. PR-URL: #25115 Reviewed-By: Steven R Loomis <firstname.lastname@example.org> Reviewed-By: Richard Lau <email@example.com> Reviewed-By: Minwoo Jung <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com>
- Loading branch information
Showing with 61 additions and 85 deletions.