Skip to content
Permalink
Browse files

util: fix wrong usage of Error.prepareStackTrace

The return value of Error.prepareStackTrace will become the result
of Error.stack accesses. Setting Error.stack inside this callback
relies on the fact that the magic get accessor detects the change in
the middle of formatting, and is unnecessary in this instance.

Refs: v8#96

PR-URL: #27250
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information...
szuend authored and addaleax committed Apr 16, 2019
1 parent dc8b57f commit 2948e96afd7fde91ec39bb5434bad93760ccfe13
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/internal/util.js
@@ -347,7 +347,7 @@ function isInsideNodeModules() {
// the perf implications should be okay.
getStructuredStack = runInNewContext(`(function() {
Error.prepareStackTrace = function(err, trace) {
err.stack = trace;

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Apr 23, 2019

Contributor

For anyone following along, docs for Error.prepareStackTrace are here: https://v8.dev/docs/stack-trace-api#customizing-stack-traces

return trace;
};
Error.stackTraceLimit = Infinity;

0 comments on commit 2948e96

Please sign in to comment.
You can’t perform that action at this time.