From 29de00093838131f1ddbdcc2840b28c855928ea2 Mon Sep 17 00:00:00 2001
From: Kyle Lamse <kyle.lamse@cgi.com>
Date: Tue, 18 Jul 2017 14:03:43 -0500
Subject: [PATCH] doc: add note for Windows build path

PR-URL: https://github.com/nodejs/node/pull/14354
Fixes: https://github.com/nodejs/node/issues/14337
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
---
 BUILDING.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/BUILDING.md b/BUILDING.md
index a2b53d943307a1..1e871cba6d567b 100644
--- a/BUILDING.md
+++ b/BUILDING.md
@@ -94,6 +94,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
 * You may want to setup [firewall rules](tools/macosx-firewall.sh)
 to avoid popups asking to accept incoming network connections when running tests:
 
+If the path to your build directory contains a space, the build will likely fail.
+
 ```console
 $ sudo ./tools/macosx-firewall.sh
 ```
@@ -174,6 +176,8 @@ Prerequisites:
   [Git for Windows](http://git-scm.com/download/win) includes Git Bash
   and tools which can be included in the global `PATH`.
 
+If the path to your build directory contains a space, the build will likely fail.
+
 ```console
 > .\vcbuild nosign
 ```