Skip to content

Commit

Permalink
test: fixing AliasedBuffer tests to enter Isolate
Browse files Browse the repository at this point in the history
AliasedBuffer tests weren't creating an v8::Isolate::Scope, and this
had negative impact on the node-chakracore branch, where expectation
is an Isoalte has been Enter()'d before being used.

PR-URL: #15536
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Mike Kaufman authored and jasnell committed Sep 25, 2017
1 parent 4f88c19 commit 29f0ad6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/cctest/test_aliased_buffer.cc
Expand Up @@ -82,6 +82,7 @@ void ReadAndValidate(v8::Isolate* isolate,

template<class NativeT, class V8T>
void ReadWriteTest(v8::Isolate* isolate) {
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);
Expand Down Expand Up @@ -114,6 +115,7 @@ void SharedBufferTest(
size_t count_A,
size_t count_B,
size_t count_C) {
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);
Expand Down

0 comments on commit 29f0ad6

Please sign in to comment.