Skip to content
Permalink
Browse files

test: remove common.PORT from multiple tests

PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
tarunbatra authored and jasnell committed Apr 16, 2017
1 parent 3cf88a4 commit 2e5188de928946c81266b149887d9b31111a5267
@@ -31,7 +31,7 @@ if (cluster.isWorker) {
const http = require('http');
http.Server(() => {

}).listen(common.PORT, '127.0.0.1');
}).listen(0, '127.0.0.1');

} else if (process.argv[2] === 'cluster') {

@@ -28,7 +28,7 @@ if (cluster.isWorker) {

// keep the worker alive
const http = require('http');
http.Server().listen(common.PORT, '127.0.0.1');
http.Server().listen(0, '127.0.0.1');

} else if (process.argv[2] === 'cluster') {

@@ -67,8 +67,8 @@ if (process.argv[2] !== 'child') {
socketConnected();
});

server.listen(common.PORT, function() {
socket = net.connect(common.PORT, '127.0.0.1', socketConnected);
server.listen(0, function() {
socket = net.connect(server.address().port, '127.0.0.1', socketConnected);
});

process.on('disconnect', function() {
@@ -32,7 +32,7 @@ if (cluster.isWorker) {
d.run(common.noop);

const http = require('http');
http.Server(common.noop).listen(common.PORT, '127.0.0.1');
http.Server(common.noop).listen(0, '127.0.0.1');

} else if (cluster.isMaster) {

@@ -10,7 +10,7 @@ if (cluster.isMaster) {
});
} else {
const server = net.createServer(common.mustNotCall());
server.listen(common.PORT, function() {
server.listen(0, function() {
server.unref();
server.ref();
server.close(function() {
@@ -13,10 +13,10 @@ if (cluster.isMaster) {
let conn, worker2;

const worker1 = cluster.fork();
worker1.on('message', common.mustCall(function() {
worker1.on('listening', common.mustCall(function(address) {
worker2 = cluster.fork();
worker2.on('online', function() {
conn = net.connect(common.PORT, common.mustCall(function() {
conn = net.connect(address.port, common.mustCall(function() {
worker1.disconnect();
worker2.disconnect();
}));
@@ -48,6 +48,4 @@ const server = net.createServer(function(c) {
c.end('bye');
});

server.listen(common.PORT, function() {
process.send('listening');
});
server.listen(0);
@@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const cluster = require('cluster');
const net = require('net');
@@ -55,7 +55,7 @@ if (cluster.isMaster) {
success = true;
});

}).listen(common.PORT, function() {
}).listen(0, function() {
const port = this.address().port;

worker = cluster.fork()

0 comments on commit 2e5188d

Please sign in to comment.
You can’t perform that action at this time.