Please sign in to comment.
src: fix delete operator on vm context
In the implementation of the vm module, if a property is successfully deleted on the sandbox, we also need to delete it on the global_proxy object. Therefore, we must not call args.GetReturnValue().Set(). We only intercept, i.e., call args.GetReturnValue().Set(), in the DeleterCallback, if Delete() failed, e.g. because the property was read only. PR-URL: #11266 Reviewed-By: Anna Henningsen <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Ben Noordhuis <email@example.com>
- Loading branch information...
Showing with 7 additions and 3 deletions.