Skip to content
Permalink
Browse files

deps: V8: silence irrelevant warning

Backport-PR-URL: #28955
PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information...
targos committed Mar 27, 2019
1 parent 434c127 commit 33f3e383dae87a5aac9671fb91355277ee20fe0e
Showing with 2 additions and 3 deletions.
  1. +1 −1 common.gypi
  2. +1 −2 deps/v8/include/v8.h
@@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

@@ -6616,8 +6616,7 @@ class PromiseRejectMessage {
typedef void (*PromiseRejectCallback)(PromiseRejectMessage message);

// --- Microtasks Callbacks ---
V8_DEPRECATE_SOON("Use *WithData version.",
typedef void (*MicrotasksCompletedCallback)(Isolate*));
typedef void (*MicrotasksCompletedCallback)(Isolate*);
typedef void (*MicrotasksCompletedCallbackWithData)(Isolate*, void*);
typedef void (*MicrotaskCallback)(void* data);

0 comments on commit 33f3e38

Please sign in to comment.
You can’t perform that action at this time.