Skip to content
Permalink
Browse files

process: improve nextTick performance

PR-URL: #25461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
mscdex committed Jan 12, 2019
1 parent 0150490 commit 34961c7b5fe8b2cf1722668666a7adcce3ab419c
@@ -2,7 +2,7 @@

const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [4e6]
n: [1e7]
});

function main({ n }) {
@@ -2,7 +2,7 @@

const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [4e6]
n: [1e7]
});

function main({ n }) {
@@ -2,7 +2,7 @@

const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [12e6]
n: [7e6]
});

function main({ n }) {
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [12e6]
n: [7e6]
});

function main({ n }) {
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [5e6]
n: [4e6]
});

function main({ n }) {
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [5e6]
n: [4e6]
});

function main({ n }) {
@@ -102,7 +102,7 @@ module.exports = class FixedQueue {
}

shift() {
const { tail } = this;
const tail = this.tail;
const next = tail.shift();
if (tail.isEmpty() && tail.next !== null) {
// If there is another queue, it forms the new tail.
@@ -71,10 +71,18 @@ function processTicksAndRejections() {

try {
const callback = tock.callback;
if (tock.args === undefined)
if (tock.args === undefined) {
callback();
else
callback(...tock.args);
} else {
const args = tock.args;
switch (args.length) {
case 1: callback(args[0]); break;
case 2: callback(args[0], args[1]); break;
case 3: callback(args[0], args[1], args[2]); break;
case 4: callback(args[0], args[1], args[2], args[3]); break;
default: callback(...args);
}
}
} finally {
if (destroyHooksExist())
emitDestroy(asyncId);
@@ -88,22 +96,6 @@ function processTicksAndRejections() {
setHasRejectionToWarn(false);
}

class TickObject {
constructor(callback, args) {
this.callback = callback;
this.args = args;

const asyncId = newAsyncId();
const triggerAsyncId = getDefaultTriggerAsyncId();
this[async_id_symbol] = asyncId;
this[trigger_async_id_symbol] = triggerAsyncId;

if (initHooksExist()) {
emitInit(asyncId, 'TickObject', triggerAsyncId, this);
}
}
}

// `nextTick()` will not enqueue any callback when the process is about to
// exit since the callback would not have a chance to be executed.
function nextTick(callback) {
@@ -127,7 +119,17 @@ function nextTick(callback) {

if (queue.isEmpty())
setHasTickScheduled(true);
queue.push(new TickObject(callback, args));
const asyncId = newAsyncId();
const triggerAsyncId = getDefaultTriggerAsyncId();
const tickObject = {
[async_id_symbol]: asyncId,
[trigger_async_id_symbol]: triggerAsyncId,
callback,
args
};
if (initHooksExist())
emitInit(asyncId, 'TickObject', triggerAsyncId, tickObject);
queue.push(tickObject);
}

let AsyncResource;

0 comments on commit 34961c7

Please sign in to comment.
You can’t perform that action at this time.