From 356923fe111c6f0364da4ae4d2d11dc878cfa69b Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 20 Feb 2019 01:43:23 +0800 Subject: [PATCH] process: move test-process-uptime to parallel In addition, do not make too many assumptions about the startup time and timer latency in test-process-uptime. Instead only test that the value is likely in the correct unit (seconds) and it should be increasing in subsequent calls. PR-URL: https://github.com/nodejs/node/pull/26206 Fixes: https://github.com/nodejs/node/issues/26205 Refs: https://github.com/nodejs/node/pull/26016 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott Reviewed-By: Richard Lau --- test/{pummel => parallel}/test-process-uptime.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename test/{pummel => parallel}/test-process-uptime.js (86%) diff --git a/test/pummel/test-process-uptime.js b/test/parallel/test-process-uptime.js similarity index 86% rename from test/pummel/test-process-uptime.js rename to test/parallel/test-process-uptime.js index 781066371eaa31..eabb6cf2661c87 100644 --- a/test/pummel/test-process-uptime.js +++ b/test/parallel/test-process-uptime.js @@ -24,14 +24,14 @@ require('../common'); const assert = require('assert'); console.error(process.uptime()); -assert.ok(process.uptime() <= 2); +// Add some wiggle room for different platforms. +// Verify that the returned value is in seconds - +// 15 seconds should be a good estimate. +assert.ok(process.uptime() <= 15); const original = process.uptime(); setTimeout(function() { const uptime = process.uptime(); - // some wiggle room to account for timer - // granularity, processor speed, and scheduling - assert.ok(uptime >= original + 2); - assert.ok(uptime <= original + 3); -}, 2000); + assert.ok(original < uptime); +}, 10);