From 3701b0230961644186fbc4ea2d6ef978601ac0f6 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 19 Nov 2017 22:24:22 +0100 Subject: [PATCH] net: remove deprecated getters for internals MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the getters introduced in 75a19fb379c2d936c6. PR-URL: https://github.com/nodejs/node/pull/17141 Refs: https://github.com/nodejs/node/pull/14449 Reviewed-By: Refael Ackermann Reviewed-By: Anatoli Papirovski Reviewed-By: Timothy Gu Reviewed-By: Michaƫl Zasso Reviewed-By: Minwoo Jung Reviewed-By: Gireesh Punathil Reviewed-By: Ben Noordhuis Reviewed-By: Evan Lucas Reviewed-By: James M Snell --- doc/api/deprecations.md | 2 +- lib/net.js | 28 ---------------------------- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 09d22c9fbee592..93baba97991c29 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -640,7 +640,7 @@ Type: End-of-Life ### DEP0073: Several internal properties of net.Server -Type: Runtime +Type: End-of-Life Accessing several internal, undocumented properties of `net.Server` instances with inappropriate names has been deprecated. diff --git a/lib/net.js b/lib/net.js index 1d64eb3c56bb84..566d8ca5f14dc9 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1734,34 +1734,6 @@ if (process.platform === 'win32') { _setSimultaneousAccepts = function(handle) {}; } -// TODO(addaleax): Remove these after the Node 9.x branch cut. -Object.defineProperty(Server.prototype, '_usingSlaves', { - get: internalUtil.deprecate(function() { - return this._usingWorkers; - }, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'), - set: internalUtil.deprecate((val) => { - this._usingWorkers = val; - }, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'), - configurable: true, enumerable: false -}); - -Object.defineProperty(Server.prototype, '_slaves', { - get: internalUtil.deprecate(function() { - return this._workers; - }, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'), - set: internalUtil.deprecate((val) => { - this._workers = val; - }, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'), - configurable: true, enumerable: false -}); - -Object.defineProperty(Server.prototype, '_setupSlave', { - value: internalUtil.deprecate(function(socketList) { - return this._setupWorker(socketList); - }, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'), - configurable: true, enumerable: false -}); - module.exports = { _createServerHandle: createServerHandle, _normalizeArgs: normalizeArgs,