From 39834bc4417a8a2a298e9a1547ed81d9b8fe36b7 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 6 May 2017 19:26:41 +0200 Subject: [PATCH] v8: backport pieces of 6226576efa82ee MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Backport removed methods from 6226576efa82ee (“[wasm] Deleted old way of checking embedder limits on wasm size.”). Ref: https://codereview.chromium.org/2772203005 Ref: https://github.com/v8/v8/commit/6226576efa82ee PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By: James M Snell --- deps/v8/include/v8.h | 10 ---------- deps/v8/src/api.cc | 11 ----------- 2 files changed, 21 deletions(-) diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 3dd9de3ba89108..1bf04571ca1bda 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -7154,16 +7154,6 @@ class V8_EXPORT Isolate { void SetAllowCodeGenerationFromStringsCallback( AllowCodeGenerationFromStringsCallback callback); - /** - * Set the callback to invoke to check if wasm compilation from - * the specified object is allowed. By default, wasm compilation - * is allowed. - * - * Similar for instantiate. - */ - void SetAllowWasmCompileCallback(AllowWasmCompileCallback callback); - void SetAllowWasmInstantiateCallback(AllowWasmInstantiateCallback callback); - /** * Check if V8 is dead and therefore unusable. This is the case after * fatal errors such as out-of-memory situations. diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 1e82a33c726348..175be217fbc291 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -8658,17 +8658,6 @@ void Isolate::SetAllowCodeGenerationFromStringsCallback( isolate->set_allow_code_gen_callback(callback); } -void Isolate::SetAllowWasmCompileCallback(AllowWasmCompileCallback callback) { - i::Isolate* isolate = reinterpret_cast(this); - isolate->set_allow_wasm_compile_callback(callback); -} - -void Isolate::SetAllowWasmInstantiateCallback( - AllowWasmInstantiateCallback callback) { - i::Isolate* isolate = reinterpret_cast(this); - isolate->set_allow_wasm_instantiate_callback(callback); -} - bool Isolate::IsDead() { i::Isolate* isolate = reinterpret_cast(this); return isolate->IsDead();