Skip to content
Permalink
Browse files

buffer: throw if both length and enc are passed

PR-URL: #4514
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
  • Loading branch information...
mafintosh authored and jasnell committed Jan 2, 2016
1 parent e51bbfd commit 3b27dd5ce15942a054904b26e3dca295806038d8
Showing with 20 additions and 0 deletions.
  1. +5 −0 lib/buffer.js
  2. +15 −0 test/sequential/test-buffer-bad-overload.js
@@ -47,6 +47,11 @@ function alignPool() {
function Buffer(arg, encoding) {
// Common case.
if (typeof arg === 'number') {
if (typeof encoding === 'string') {
throw new Error(
'If encoding is specified then the first argument must be a string'
);
}
// If less than zero, or NaN.
if (arg < 0 || arg !== arg)
arg = 0;
@@ -0,0 +1,15 @@
'use strict';
require('../common');
const assert = require('assert');

assert.doesNotThrow(function() {
new Buffer(10);
});

assert.throws(function() {
new Buffer(10, 'hex');
});

assert.doesNotThrow(function() {
new Buffer('deadbeaf', 'hex');
});

0 comments on commit 3b27dd5

Please sign in to comment.
You can’t perform that action at this time.