Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
tls: remove unused arg to createSecureContext()
The context arg is unused by node or its test suites and undocumented.
Remove it.
PR-URL: #24241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Loading branch information
Showing
1 changed file
with
6 additions
and
17 deletions .
+6
−17
lib/_tls_common.js
@@ -35,22 +35,13 @@ const { SSL_OP_CIPHER_SERVER_PREFERENCE } = internalBinding('constants').crypto;
let toBuf = null ;
const { SecureContext : NativeSecureContext } = internalBinding ( 'crypto' ) ;
function SecureContext ( secureProtocol , secureOptions , context ) {
function SecureContext ( secureProtocol , secureOptions ) {
if ( ! ( this instanceof SecureContext ) ) {
return new SecureContext ( secureProtocol , secureOptions , context ) ;
return new SecureContext ( secureProtocol , secureOptions ) ;
}
if ( context ) {
this . context = context ;
} else {
this . context = new NativeSecureContext ( ) ;
if ( secureProtocol ) {
this . context . init ( secureProtocol ) ;
} else {
this . context . init ( ) ;
}
}
this . context = new NativeSecureContext ( ) ;
this . context . init ( secureProtocol ) ;
if ( secureOptions ) this . context . setOptions ( secureOptions ) ;
}
@@ -68,19 +59,17 @@ function validateKeyCert(name, value) {
exports . SecureContext = SecureContext ;
exports . createSecureContext = function createSecureContext ( options , context ) {
exports . createSecureContext = function createSecureContext ( options ) {
if ( ! options ) options = { } ;
var secureOptions = options . secureOptions ;
if ( options . honorCipherOrder )
secureOptions |= SSL_OP_CIPHER_SERVER_PREFERENCE ;
const c = new SecureContext ( options . secureProtocol , secureOptions , context ) ;
const c = new SecureContext ( options . secureProtocol , secureOptions ) ;
var i ;
var val ;
if ( context ) return c ;
// NOTE: It's important to add CA before the cert to be able to load
// cert's issuer in C++ code.
const { ca } = options ;
Toggle all file notes
Toggle all file annotations