Skip to content
Permalink
Browse files

build: unbreak --with-intl=system-icu build

Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: #28052
PR-URL: #28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
bnoordhuis authored and Trott committed Jun 7, 2019
1 parent 30f285d commit 3cdd5a286e8f758182f2bc90bdc56c267b253245
Showing with 0 additions and 7 deletions.
  1. +0 −7 tools/v8_gypfiles/v8.gyp
@@ -393,13 +393,6 @@
'<(icu_gyp_path):icui18n',
'<(icu_gyp_path):icuuc',
],
'direct_dependent_settings': {
'include_dirs': [
'<(icu_path)/source/common',
'<(icu_path)/source/i18n',
'<(icu_path)/source/tools/toolutil',
],
},
}],
],
}, # v8_maybe_icu

0 comments on commit 3cdd5a2

Please sign in to comment.
You can’t perform that action at this time.