From 3dbcc3d2d935889ea6df5968d1e14d2942758ac1 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Thu, 7 Jul 2016 20:14:51 -0700
Subject: [PATCH] test: fix flaky test-*-connect-address-family

Skip tests if localhost does not resolve to ::1.

Fixes: https://github.com/nodejs/node/issues/7288
PR-URL: https://github.com/nodejs/node/pull/7605
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
---
 .../test-https-connect-address-family.js      | 50 ++++++++++++-------
 .../test-tls-connect-address-family.js        | 48 +++++++++++-------
 2 files changed, 63 insertions(+), 35 deletions(-)

diff --git a/test/parallel/test-https-connect-address-family.js b/test/parallel/test-https-connect-address-family.js
index 8d7c406924f830..12a7fd282a4346 100644
--- a/test/parallel/test-https-connect-address-family.js
+++ b/test/parallel/test-https-connect-address-family.js
@@ -1,28 +1,42 @@
 'use strict';
 const common = require('../common');
-const assert = require('assert');
-const https = require('https');
 
 if (!common.hasIPv6) {
   common.skip('no IPv6 support');
   return;
 }
 
-const ciphers = 'AECDH-NULL-SHA';
-https.createServer({ ciphers }, function(req, res) {
-  this.close();
-  res.end();
-}).listen(0, '::1', function() {
-  const options = {
-    host: 'localhost',
-    port: this.address().port,
-    family: 6,
-    ciphers: ciphers,
-    rejectUnauthorized: false,
-  };
-  // Will fail with ECONNREFUSED if the address family is not honored.
-  https.get(options, common.mustCall(function() {
-    assert.strictEqual('::1', this.socket.remoteAddress);
-    this.destroy();
+const assert = require('assert');
+const https = require('https');
+const dns = require('dns');
+
+function runTest() {
+  const ciphers = 'AECDH-NULL-SHA';
+  https.createServer({ ciphers }, common.mustCall(function(req, res) {
+    this.close();
+    res.end();
+  })).listen(common.PORT, '::1', common.mustCall(function() {
+    const options = {
+      host: 'localhost',
+      port: common.PORT,
+      family: 6,
+      ciphers: ciphers,
+      rejectUnauthorized: false,
+    };
+    // Will fail with ECONNREFUSED if the address family is not honored.
+    https.get(options, common.mustCall(function() {
+      assert.strictEqual('::1', this.socket.remoteAddress);
+      this.destroy();
+    }));
   }));
+}
+
+dns.lookup('localhost', {family: 6, all: true}, (err, addresses) => {
+  if (err)
+    throw err;
+
+  if (addresses.some((val) => val.address === '::1'))
+    runTest();
+  else
+    common.skip('localhost does not resolve to ::1');
 });
diff --git a/test/parallel/test-tls-connect-address-family.js b/test/parallel/test-tls-connect-address-family.js
index f069d21e54ad92..e21cf540e0d522 100644
--- a/test/parallel/test-tls-connect-address-family.js
+++ b/test/parallel/test-tls-connect-address-family.js
@@ -1,27 +1,41 @@
 'use strict';
 const common = require('../common');
-const assert = require('assert');
-const tls = require('tls');
 
 if (!common.hasIPv6) {
   common.skip('no IPv6 support');
   return;
 }
 
-const ciphers = 'AECDH-NULL-SHA';
-tls.createServer({ ciphers }, function() {
-  this.close();
-}).listen(0, '::1', function() {
-  const options = {
-    host: 'localhost',
-    port: this.address().port,
-    family: 6,
-    ciphers: ciphers,
-    rejectUnauthorized: false,
-  };
-  // Will fail with ECONNREFUSED if the address family is not honored.
-  tls.connect(options).once('secureConnect', common.mustCall(function() {
-    assert.strictEqual('::1', this.remoteAddress);
-    this.destroy();
+const assert = require('assert');
+const tls = require('tls');
+const dns = require('dns');
+
+function runTest() {
+  const ciphers = 'AECDH-NULL-SHA';
+  tls.createServer({ ciphers }, common.mustCall(function() {
+    this.close();
+  })).listen(common.PORT, '::1', common.mustCall(function() {
+    const options = {
+      host: 'localhost',
+      port: common.PORT,
+      family: 6,
+      ciphers: ciphers,
+      rejectUnauthorized: false,
+    };
+    // Will fail with ECONNREFUSED if the address family is not honored.
+    tls.connect(options).once('secureConnect', common.mustCall(function() {
+      assert.strictEqual('::1', this.remoteAddress);
+      this.destroy();
+    }));
   }));
+}
+
+dns.lookup('localhost', {family: 6, all: true}, (err, addresses) => {
+  if (err)
+    throw err;
+
+  if (addresses.some((val) => val.address === '::1'))
+    runTest();
+  else
+    common.skip('localhost does not resolve to ::1');
 });