Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
test: formalize exposure of internal bindings
moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it PR-URL: #18698 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Loading branch information
Showing
with
15 additions
and 7 deletions.
- +0 −5 lib/internal/loader/ModuleWrap.js
- +13 −0 lib/internal/test/binding.js
- +1 −1 node.gyp
- +1 −1 test/parallel/test-internal-module-wrap.js
@@ -0,0 +1,13 @@ | ||
'use strict'; | ||
|
||
process.emitWarning( | ||
'These APIs are exposed only for testing and are not ' + | ||
'tracked by any versioning system or deprecation process.', | ||
'internal/test/binding'); | ||
|
||
// These exports should be scoped as specifically as possible | ||
// to avoid exposing APIs because even with that warning and | ||
// this file being internal people will still try to abuse it. | ||
module.exports = { | ||
ModuleWrap: internalBinding('module_wrap').ModuleWrap, | ||
}; |