Permalink
Browse files

test: add error code tests in dgram test

Improve error validation in test-dgram-send-bad-arguments.

PR-URL: #24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
MarkArranz authored and Trott committed Nov 7, 2018
1 parent 8884a98 commit 457cde3167ec474aa57948a2b1fa58e9c4a55f4c
Showing with 29 additions and 6 deletions.
  1. +29 −6 test/parallel/test-dgram-send-bad-arguments.js
@@ -20,25 +20,48 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const buf = Buffer.from('test');
const host = '127.0.0.1';
const sock = dgram.createSocket('udp4');
assert.throws(() => {
sock.send();
}, TypeError); // First argument should be a buffer.
// First argument should be a buffer.
common.expectsError(
() => { sock.send(); },
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "buffer" argument must be one of type ' +
'Buffer, Uint8Array, or string. Received type undefined'
}
);
// send(buf, offset, length, port, host)
assert.throws(() => { sock.send(buf, 1, 1, -1, host); }, RangeError);
assert.throws(() => { sock.send(buf, 1, 1, 0, host); }, RangeError);
assert.throws(() => { sock.send(buf, 1, 1, 65536, host); }, RangeError);
// send(buf, port, host)
assert.throws(() => { sock.send(23, 12345, host); }, TypeError);
common.expectsError(
() => { sock.send(23, 12345, host); },
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "buffer" argument must be one of type ' +
'Buffer, Uint8Array, or string. Received type number'
}
);
// send([buf1, ..], port, host)
assert.throws(() => { sock.send([buf, 23], 12345, host); }, TypeError);
common.expectsError(
() => { sock.send([buf, 23], 12345, host); },
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "buffer list arguments" argument must be one of type ' +
'Buffer or string. Received type object'
}
);

0 comments on commit 457cde3

Please sign in to comment.