From 4652dfdc888cc1a2fc2aeb7c6000c84239a5ebf1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Sat, 4 Mar 2023 22:12:48 +0000 Subject: [PATCH] src: remove TLSEXT_TYPE_alpn guard TLSEXT_TYPE_application_layer_protocol_negotiation is always defined in all supported OpenSSL versions. We also use this macro elsewhere without guards, so if it did not exist, compilation would have already failed. Besides that, it makes little sense to provide a TLS 1.3 implementation that does not support ALPN. PR-URL: https://github.com/nodejs/node/pull/46956 Reviewed-By: Ben Noordhuis Reviewed-By: Filip Skokan Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca --- src/node_constants.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_constants.cc b/src/node_constants.cc index 3269e3003acd4d..34496673a97072 100644 --- a/src/node_constants.cc +++ b/src/node_constants.cc @@ -1032,10 +1032,8 @@ void DefineCryptoConstants(Local target) { NODE_DEFINE_CONSTANT(target, DH_NOT_SUITABLE_GENERATOR); #endif -#ifdef TLSEXT_TYPE_application_layer_protocol_negotiation #define ALPN_ENABLED 1 NODE_DEFINE_CONSTANT(target, ALPN_ENABLED); -#endif #ifdef RSA_PKCS1_PADDING NODE_DEFINE_CONSTANT(target, RSA_PKCS1_PADDING);