Skip to content
Permalink
Browse files

test: refactored test-crypto-random.js

Replaced `var` by `const` for constant variables, enforced
strict equality check, and replaced custom callback execution
check by `common.mustCall`.

PR-URL: #8632
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
  • Loading branch information...
Tobias Kahse authored and imyller committed Sep 17, 2016
1 parent 9fb59df commit 48142bcf4fea56ddab0bcaa815a4316312694c4f
Showing with 6 additions and 19 deletions.
  1. +6 −19 test/parallel/test-crypto-random.js
@@ -1,12 +1,12 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var crypto = require('crypto');
const crypto = require('crypto');

crypto.DEFAULT_ENCODING = 'buffer';

@@ -29,27 +29,14 @@ process.setMaxListeners(256);
});

[0, 1, 2, 4, 16, 256, 1024].forEach(function(len) {
f(len, checkCall(function(ex, buf) {
assert.equal(null, ex);
assert.equal(len, buf.length);
f(len, common.mustCall(function(ex, buf) {
assert.strictEqual(null, ex);
assert.strictEqual(len, buf.length);
assert.ok(Buffer.isBuffer(buf));
}));
});
});

// assert that the callback is indeed called
function checkCall(cb, desc) {
var called_ = false;

process.on('exit', function() {
assert.equal(true, called_, desc || ('callback not called: ' + cb));
});

return function() {
return called_ = true, cb.apply(cb, Array.prototype.slice.call(arguments));
};
}

// #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
// length exceeds max acceptable value"
assert.throws(function() {

0 comments on commit 48142bc

Please sign in to comment.
You can’t perform that action at this time.