Skip to content
Browse files

src: remove outdated todo from

TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <>
Reviewed-By: James M Snell <>
  • Loading branch information
barnski authored and BridgeAR committed Sep 19, 2017
1 parent 049a8d7 commit 4dc920af6e30e08cedc1766891ef29c9cb41a9d8
Showing with 0 additions and 1 deletion.
  1. +0 −1 src/
@@ -1627,7 +1627,6 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) {
const char hex[] = "0123456789ABCDEF";
char fingerprint[EVP_MAX_MD_SIZE * 3];

// TODO(indutny): Unify it with buffer's code
for (i = 0; i < md_size; i++) {
fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4];
fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)];

0 comments on commit 4dc920a

Please sign in to comment.
You can’t perform that action at this time.