Skip to content
Browse files

tools: improve prerequisites for test-all-suites

The prerequisistes for test-all-suites were running some tests
themselves. When one of those tests failed during a coverage run, it
resulted in artificially low coverage. Fix the prerequisites to only
build stuff, not test.

PR-URL: #25892
Reviewed-By: Refael Ackermann <>
Reviewed-By: Anna Henningsen <>
  • Loading branch information
Trott committed Feb 3, 2019
1 parent fba96ca commit 4deb23a2f66e576be96c3bb856e5199cb3439865
Showing with 1 addition and 1 deletion.
  1. +1 −1 Makefile
@@ -467,7 +467,7 @@ test-all-valgrind: test-build
$(PYTHON) tools/ $(PARALLEL_ARGS) --mode=debug,release --valgrind

.PHONY: test-all-suites
test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites.
test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
$(PYTHON) tools/ $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*

CI_NATIVE_SUITES ?= addons js-native-api node-api

0 comments on commit 4deb23a

Please sign in to comment.