From 514ef7452c38fcf0821b5b2ec3b25ae568e3bb3f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 4 Sep 2017 18:44:25 -0700 Subject: [PATCH] test: make test-http-agent-maxsockets robust MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On a slow/busy machine, `test-http-agent-maxsockets` can fail if the test takes longer than 5 seconds because that is the default value for `server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test robust. PR-URL: https://github.com/nodejs/node/pull/15192 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater Reviewed-By: Tobias Nießen --- test/parallel/test-http-agent-maxsockets.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/parallel/test-http-agent-maxsockets.js b/test/parallel/test-http-agent-maxsockets.js index 66fffba250513f..4d422f4a90b4f9 100644 --- a/test/parallel/test-http-agent-maxsockets.js +++ b/test/parallel/test-http-agent-maxsockets.js @@ -15,6 +15,8 @@ const server = http.createServer(common.mustCall((req, res) => { res.end('hello world'); }, 2)); +server.keepAliveTimeout = 0; + function get(path, callback) { return http.get({ host: 'localhost',