Permalink
Browse files

http: use strict comparison

PR-URL: #17011
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information...
leeseean authored and BridgeAR committed Nov 14, 2017
1 parent 7d2b08a commit 5164a12618cf60150db621aebe1f3d89efb9b9aa
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/_http_client.js
@@ -44,7 +44,7 @@ const errors = require('internal/errors');
const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;
function validateHost(host, name) {
if (host != null && typeof host !== 'string') {
if (host !== null && host !== undefined && typeof host !== 'string') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', `options.${name}`,
['string', 'undefined', 'null'], host);
}
@@ -113,7 +113,7 @@ function ClientRequest(options, cb) {
var method = options.method;
var methodIsString = (typeof method === 'string');
if (method != null && !methodIsString) {
if (method !== null && method !== undefined && !methodIsString) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'method',
'string', method);
}

0 comments on commit 5164a12

Please sign in to comment.