Permalink
Browse files

src: fix --abort_on_uncaught_exception arg parsing

Fix c0bde73, which inadvertently introduced a use of strcmp() without
correctly comparing its return to zero. Caught by coverity:

        >>>     CID 169223:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
        >>>     The "or" condition "strcmp(arg, "--abort-on-uncaught-exception") || strcmp(arg, "--abort_on_uncaught_exception")" will always be true because "arg" cannot be equal to two different values at the same time, so it must be not equal to at least one of them.
        3909         } else if (strcmp(arg, "--abort-on-uncaught-exception") ||
        3910                    strcmp(arg, "--abort_on_uncaught_exception")) {
        3911           abort_on_uncaught_exception = true;
        3912           // Also a V8 option.  Pass through as-is.
        3913           new_v8_argv[new_v8_argc] = arg;
        3914           new_v8_argc += 1;

PR-URL: #13004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information...
sam-github committed May 12, 2017
1 parent 8035527 commit 53dae8383309b8d1a7ccdf81bbddd5e4e594b48d
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/node.cc
View
@@ -3906,8 +3906,8 @@ static void ParseArgs(int* argc,
} else if (strcmp(arg, "--") == 0) {
index += 1;
break;
} else if (strcmp(arg, "--abort-on-uncaught-exception") ||
strcmp(arg, "--abort_on_uncaught_exception")) {
} else if (strcmp(arg, "--abort-on-uncaught-exception") == 0 ||
strcmp(arg, "--abort_on_uncaught_exception") == 0) {
abort_on_uncaught_exception = true;
// Also a V8 option. Pass through as-is.
new_v8_argv[new_v8_argc] = arg;

0 comments on commit 53dae83

Please sign in to comment.