Skip to content
Permalink
Browse files

test: refactor stdio handling in test-esm-cjs-main

Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information...
richardlau authored and targos committed Dec 21, 2018
1 parent 99a5af6 commit 58af085d9f299d2e0da69483840902f664f1d917
Showing with 9 additions and 10 deletions.
  1. +9 −10 test/es-module/test-esm-cjs-main.js
@@ -8,21 +8,20 @@ const assert = require('assert');
const entry = fixtures.path('/es-modules/cjs.js');

const child = spawn(process.execPath, ['--experimental-modules', entry]);
let experimentalWarning = false;
let validatedExecution = false;
let stderr = '';
child.stderr.setEncoding('utf8');
child.stderr.on('data', (data) => {
if (!experimentalWarning) {
experimentalWarning = true;
return;
}
throw new Error(data.toString());
stderr += data;
});
let stdout = '';
child.stdout.setEncoding('utf8');
child.stdout.on('data', (data) => {
assert.strictEqual(data.toString(), 'executed\n');
validatedExecution = true;
stdout += data;
});
child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(validatedExecution, true);
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
assert.strictEqual(stdout, 'executed\n');
assert.strictEqual(stderr, `(node:${child.pid}) ` +
'ExperimentalWarning: The ESM module loader is experimental.\n');
}));

0 comments on commit 58af085

Please sign in to comment.
You can’t perform that action at this time.