Permalink
Browse files

test: remove arbitrary timer

`test-dgram-send-callback-buffer-length` was timing out (via the
200ms timeout in the code) on FreeBSD in CI. The 200ms timeout is
arbitrary and not necessary. Remove it.

PR-URL: #9197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
Trott authored and jasnell committed Oct 19, 2016
1 parent 3e2bafe commit 5ba02bf5db798235ef24a63441a5581a9e2de686
Showing with 2 additions and 7 deletions.
  1. +2 −7 test/parallel/test-dgram-send-callback-buffer-length.js
@@ -6,18 +6,13 @@ const assert = require('assert');
const dgram = require('dgram');
const client = dgram.createSocket('udp4');
const timer = setTimeout(function() {
throw new Error('Timeout');
}, common.platformTimeout(200));
const buf = Buffer.allocUnsafe(256);
const offset = 20;
const len = buf.length - offset;
const messageSent = common.mustCall(function messageSent(err, bytes) {
assert.notEqual(bytes, buf.length);
assert.equal(bytes, buf.length - offset);
clearTimeout(timer);
assert.notStrictEqual(bytes, buf.length);
assert.strictEqual(bytes, buf.length - offset);
client.close();
});

0 comments on commit 5ba02bf

Please sign in to comment.