Permalink
Browse files

buffer: fix writeUInt16BE range check

Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
mscdex authored and Trott committed Nov 6, 2018
1 parent 00d412d commit 5c201b6d477525a080b11d1bd49a7c94fe81f8ac
Showing with 13 additions and 1 deletion.
  1. +1 −1 lib/internal/buffer.js
  2. +12 −0 test/parallel/test-buffer-writeuint.js
@@ -667,7 +667,7 @@ function writeU_Int16BE(buf, value, offset, min, max) {
}
function writeUInt16BE(value, offset = 0) {
return writeU_Int16BE(this, value, offset, 0, 0xffffffff);
return writeU_Int16BE(this, value, offset, 0, 0xffff);
}
function writeIntLE(value, offset, byteLength) {
@@ -84,6 +84,18 @@ const assert = require('assert');
data.writeUInt16BE(value, 0);
assert.ok(data.equals(new Uint8Array([0xff, 0x80, 0x43, 0x23])));
value = 0xfffff;
['writeUInt16BE', 'writeUInt16LE'].forEach((fn) => {
assert.throws(
() => data[fn](value, 0),
{
code: 'ERR_OUT_OF_RANGE',
message: 'The value of "value" is out of range. ' +
`It must be >= 0 and <= 65535. Received ${value}`
}
);
});
}
// Test 32 bit

0 comments on commit 5c201b6

Please sign in to comment.