Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: fix flaky test-timers-blocking-callback
This test was failing on FreeBSD from time to time in the project CI. The bug the test was written for would guarantee that the timer would fire at least 100ms late, but the assertion was firing if it was more than 50ms late. This changes the assertion to fire when the timer is more than 100ms late. I ran a modified version of this test using 0.10.38 (which has the bug) and 0.10.39 (which has the fix) to confirm that it still fails in the buggy one and passes in the fixed one. PR-URL: #9198 Reviewed-By: Jeremiah Senkpiel <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Julien Gilli <email@example.com>
- Loading branch information
Showing with 5 additions and 6 deletions.