Permalink
Browse files

test: refactored test-repl-persistent-history

PR-URL: #12703
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
cool88 authored and addaleax committed May 2, 2017
1 parent dac9f42 commit 6058c4349fd89c61cf7feeeeac9186e9842fbb20
Showing with 3 additions and 8 deletions.
  1. +3 −8 test/parallel/test-repl-persistent-history.js
@@ -204,12 +204,6 @@ const tests = [
const numtests = tests.length;
let testsNotRan = tests.length;
process.on('beforeExit', () =>
assert.strictEqual(testsNotRan, 0)
);
function cleanupTmpFile() {
try {
// Write over the file, clearing any history
@@ -225,6 +219,8 @@ function cleanupTmpFile() {
fs.createReadStream(historyFixturePath)
.pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest());
const runTestWrap = common.mustCall(runTest, numtests);
function runTest(assertCleaned) {
const opts = tests.shift();
if (!opts) return; // All done
@@ -294,8 +290,7 @@ function runTest(assertCleaned) {
try {
// Ensure everything that we expected was output
assert.strictEqual(expected.length, 0);
testsNotRan--;
setImmediate(runTest, cleaned);
setImmediate(runTestWrap, cleaned);
} catch (err) {
console.error(`Failed test # ${numtests - tests.length}`);
throw err;

0 comments on commit 6058c43

Please sign in to comment.