Permalink
Browse files

test: don't skip when common.mustCall() is pending

The test parallel/test-dgram-multicast-set-interface.js was
calling common.skip() on hosts that do not support IPv6. However,
by this point, there were several outstanding common.mustCall()
invocations. The process.exit() in common.skip() triggered
those common.mustCall()s as errors.

Fixes: #15419
PR-URL: #15421
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
cjihrig committed Sep 14, 2017
1 parent b0d3bec commit 631c59b946113faa764f7c323475eee3d9a0f917
Showing with 4 additions and 3 deletions.
  1. +4 −3 test/parallel/test-dgram-multicast-set-interface.js
@@ -72,10 +72,11 @@ const dgram = require('dgram');
}));
}
if (!common.hasIPv6) {
common.skip('Skipping udp6 tests, no IPv6 support.');
// If IPv6 is not supported, skip the rest of the test. However, don't call
// common.skip(), which calls process.exit() while there is outstanding
// common.mustCall() activity.
if (!common.hasIPv6)
return;
}
{
const socket = dgram.createSocket('udp6');

0 comments on commit 631c59b

Please sign in to comment.