Permalink
Browse files

test: enable node-module-version/test.js with debug

Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: #9093
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
danbev authored and jasnell committed Oct 14, 2016
1 parent bd7d7a7 commit 67e2b92e218f418b07e3c73c96bc753739e6510d
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/addons/node-module-version/test.js
@@ -1,11 +1,11 @@
'use strict';
require('../../common');
const common = require('../../common');
const assert = require('assert');
const re = new RegExp(
'was compiled against a different Node.js version using\n' +
'NODE_MODULE_VERSION 42. This version of Node.js requires\n' +
`NODE_MODULE_VERSION ${process.versions.modules}.`);
assert.throws(() => require('./build/Release/binding'), re);
assert.throws(() => require(`./build/${common.buildType}/binding`), re);

0 comments on commit 67e2b92

Please sign in to comment.