Please sign in to comment.
http: set socket.server unconditionally
This is useful for situations in which the socket was not created for HTTP, e.g. when using arbitrary `Duplex` streams. (The added test fails because previously, `socket.server.emit()` would not work for emitting the `clientError` event, as `socket.server` was `undefined`.) PR-URL: #30571 Reviewed-By: Yongsheng Zhang <firstname.lastname@example.org> Reviewed-By: Luigi Pinca <email@example.com> Reviewed-By: Trivikram Kamat <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com>
- Loading branch information
Showing with 15 additions and 2 deletions.