Please sign in to comment.
src: clean up MultiIsolatePlatform interface
- Since this was introduced, V8 has effectively started requiring that the platform knows of the `Isolate*` before we (or an embedder) create our `IsolateData` structure; therefore, (un)registering it from the `IsolateData` constructor/destructor doesn’t make much sense anymore. - Instead, we can require that the register/unregister functions are only called once, simplifying the implementation a bit. - Add a callback that we can use to know when the platform has cleaned up its resources associated with a given `Isolate`. In particular, this means that in the Worker code, we don’t need to rely on what are essentially guesses about the number of event loop turns that we need in order to have everything cleaned up. PR-URL: #26384 Reviewed-By: Daniel Bevenius <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Matteo Collina <email@example.com> Reviewed-By: Joyee Cheung <firstname.lastname@example.org>
- Loading branch information...
Showing with 59 additions and 37 deletions.