diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index f3d63d12a7c1c5..cf1e97397ab625 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -902,11 +902,21 @@ Certain versions of `node::MakeCallback` APIs available to native modules are deprecated. Please use the versions of the API that accept an `async_context` parameter. + +### DEP0100: process.assert() + +Type: Runtime + +`process.assert()` is deprecated. Please use the [`assert`][] module instead. + +This was never a documented feature. + [`--pending-deprecation`]: cli.html#cli_pending_deprecation [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size [`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array [`Buffer.from(buffer)`]: buffer.html#buffer_class_method_buffer_from_buffer [`Buffer.isBuffer()`]: buffer.html#buffer_class_method_buffer_isbuffer_obj +[`assert`]: assert.html [`clearInterval()`]: timers.html#timers_clearinterval_timeout [`clearTimeout()`]: timers.html#timers_cleartimeout_timeout [`EventEmitter.listenerCount(emitter, eventName)`]: events.html#events_eventemitter_listenercount_emitter_eventname diff --git a/lib/internal/process.js b/lib/internal/process.js index 776129a140fe68..371281dfd44041 100644 --- a/lib/internal/process.js +++ b/lib/internal/process.js @@ -3,11 +3,15 @@ const errors = require('internal/errors'); const util = require('util'); const constants = process.binding('constants').os.signals; - -const assert = process.assert = function(x, msg) { - if (!x) throw new errors.Error('ERR_ASSERTION', msg || 'assertion error'); -}; - +const assert = require('assert').strict; +const { deprecate } = require('internal/util'); + +process.assert = deprecate( + function(x, msg) { + if (!x) throw new errors.Error('ERR_ASSERTION', msg || 'assertion error'); + }, + 'process.assert() is deprecated. Please use the `assert` module instead.', + 'DEP0100'); function setup_performance() { require('perf_hooks'); diff --git a/test/parallel/test-process-assert.js b/test/parallel/test-process-assert.js index f62cf1a5ced1c7..74792eebb7bd2f 100644 --- a/test/parallel/test-process-assert.js +++ b/test/parallel/test-process-assert.js @@ -2,6 +2,12 @@ const common = require('../common'); const assert = require('assert'); +common.expectWarning( + 'DeprecationWarning', + 'process.assert() is deprecated. Please use the `assert` module instead.', + 'DEP0100' +); + assert.strictEqual(process.assert(1, 'error'), undefined); common.expectsError(() => { process.assert(undefined, 'errorMessage'); @@ -9,13 +15,11 @@ common.expectsError(() => { code: 'ERR_ASSERTION', type: Error, message: 'errorMessage' -} -); +}); common.expectsError(() => { process.assert(false); }, { code: 'ERR_ASSERTION', type: Error, message: 'assertion error' -} -); +});