Skip to content
Permalink
Browse files

cares: Support malloc(0) scenarios for AIX

Many places in cares library, when the stream data arrives
from the network with respect to dns and reverse dns
resolution, they are populated into data structures created
dymaically based on the size of the data. Malloc is heavily
used for such cases.

Often, based on the data length, malloc(0) is invoked. Linux
behavior on zero byte allocation is to return a valid pointer
where in AIX, it always return NULL.

This manifestst as test failure of test/internet/test-dns.js

Solution is to build cares with Linux compatible malloc behavior

PR-URL: #6305
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information...
gireeshpunathil authored and jasnell committed Apr 20, 2016
1 parent c764c44 commit 704b68aeb9a5b2b8fb5448de1d75e8edcd76d0d0
Showing with 4 additions and 0 deletions.
  1. +4 −0 deps/cares/cares.gyp
@@ -12,6 +12,10 @@
[ 'OS=="aix"', {
'include_dirs': [ 'config/aix' ],
'sources': [ 'config/aix/ares_config.h' ],
'defines': [
# Support for malloc(0)
'_LINUX_SOURCE_COMPAT=1',
'_ALL_SOURCE=1'],
}],
['OS=="solaris"', {
'defines': [

0 comments on commit 704b68a

Please sign in to comment.
You can’t perform that action at this time.