Please sign in to comment.
build: fix building with ninja on linux
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed to `ninja` on OS X which places it outside of that directory. Furthermore, the expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`. This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the correct values for `ninja` on Linux specifically. PR-URL: #11348 Fixes: #9861 Reviewed-By: Ben Noordhuis <firstname.lastname@example.org> Reviewed-By: Sam Roberts <email@example.com> Reviewed-By: Gibson Fahnestock <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com>
- Loading branch information...