From 71aaf590c13d597add3d34f41c8fe70e909ba385 Mon Sep 17 00:00:00 2001 From: Brian White Date: Mon, 19 Aug 2019 23:26:11 -0400 Subject: [PATCH] buffer: correct indexOf() error message PR-URL: https://github.com/nodejs/node/pull/29217 Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen --- lib/buffer.js | 2 +- test/parallel/test-bootstrap-modules.js | 1 + test/parallel/test-buffer-includes.js | 2 +- test/parallel/test-buffer-indexof.js | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index 85c2df49c8ca80..ce2d7c63b5b911 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -907,7 +907,7 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir) { } throw new ERR_INVALID_ARG_TYPE( - 'value', ['string', 'Buffer', 'Uint8Array'], val + 'value', ['number', 'string', 'Buffer', 'Uint8Array'], val ); } diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js index 24ba7d34f57981..69aae7f9b7044d 100644 --- a/test/parallel/test-bootstrap-modules.js +++ b/test/parallel/test-bootstrap-modules.js @@ -22,6 +22,7 @@ const expectedModules = new Set([ 'Internal Binding native_module', 'Internal Binding options', 'Internal Binding process_methods', + 'Internal Binding string_decoder', 'Internal Binding task_queue', 'Internal Binding timers', 'Internal Binding trace_events', diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js index ca5b94f9d9fa46..794822f13ac873 100644 --- a/test/parallel/test-buffer-includes.js +++ b/test/parallel/test-buffer-includes.js @@ -282,7 +282,7 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) { { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, - message: 'The "value" argument must be one of type string, ' + + message: 'The "value" argument must be one of type number, string, ' + `Buffer, or Uint8Array. Received type ${typeof val}` } ); diff --git a/test/parallel/test-buffer-indexof.js b/test/parallel/test-buffer-indexof.js index 44787d73aab298..3059e13780e5bd 100644 --- a/test/parallel/test-buffer-indexof.js +++ b/test/parallel/test-buffer-indexof.js @@ -357,7 +357,7 @@ assert.strictEqual(Buffer.from('aaaaa').indexOf('b', 'ucs2'), -1); { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, - message: 'The "value" argument must be one of type string, ' + + message: 'The "value" argument must be one of type number, string, ' + `Buffer, or Uint8Array. Received type ${typeof val}` } );