Please sign in to comment.
build: fix version checks in gyp files
Make `distutils.version.StrictVersion` available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: `StrictVersion` does *not* like empty strings so this commit adds truthiness guards. The helper could deal with those but I felt it better to make it explicit. Fixes: #29927 PR-URL: #29931 Reviewed-By: Michaël Zasso <firstname.lastname@example.org> Reviewed-By: Richard Lau <email@example.com> Reviewed-By: Colin Ihrig <firstname.lastname@example.org>
- Loading branch information
Showing with 8 additions and 3 deletions.