Permalink
Browse files

test: remove unused function arguments in async-hooks tests

Remove unused function arguments in three async-hooks tests and
improve test consistancy.

PR-URL: #24406
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
blacksun1 authored and Trott committed Nov 17, 2018
1 parent 9730903 commit 738e076556f68bf9bca36f447d8a7cc64769b48e
@@ -8,11 +8,11 @@ const { checkInvocations } = require('./hook-checks');
if (!common.isMainThread)
common.skip('Worker bootstrapping works differently -> different async IDs');
const p = new Promise(common.mustCall(function executor(resolve, reject) {
const p = new Promise(common.mustCall(function executor(resolve) {
resolve(5);
}));
p.then(function afterresolution(val) {
p.then(function afterResolution(val) {
assert.strictEqual(val, 5);
return val;
});
@@ -13,24 +13,22 @@ const hooks = initHooks();
hooks.enable();
const p = (new Promise(common.mustCall(executor)));
p.then(afterresolution);
function executor(resolve, reject) {
const as = hooks.activitiesOfTypes('PROMISE');
assert.strictEqual(as.length, 1);
const a = as[0];
checkInvocations(a, { init: 1 }, 'while in promise executor');
resolve(5);
}
function afterresolution(val) {
const p = new Promise(common.mustCall(executor));
p.then(function afterResolution(val) {
assert.strictEqual(val, 5);
const as = hooks.activitiesOfTypes('PROMISE');
assert.strictEqual(as.length, 2);
checkInvocations(as[0], { init: 1 }, 'after resolution parent promise');
checkInvocations(as[1], { init: 1, before: 1 },
'after resolution child promise');
});
function executor(resolve) {
const as = hooks.activitiesOfTypes('PROMISE');
assert.strictEqual(as.length, 1);
const a = as[0];
checkInvocations(a, { init: 1 }, 'while in promise executor');
resolve(5);
}
process.on('exit', onexit);
@@ -5,15 +5,15 @@ const assert = require('assert');
const initHooks = require('./init-hooks');
const { checkInvocations } = require('./hook-checks');
const p = new Promise(common.mustCall(function executor(resolve, reject) {
const p = new Promise(common.mustCall(function executor(resolve) {
resolve(5);
}));
// init hooks after promise was created
const hooks = initHooks({ allowNoInit: true });
hooks.enable();
p.then(function afterresolution(val) {
p.then(function afterResolution(val) {
assert.strictEqual(val, 5);
const as = hooks.activitiesOfTypes('PROMISE');
assert.strictEqual(as.length, 1);

0 comments on commit 738e076

Please sign in to comment.